Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Google Play Music Support #31

Closed
cj-zeiger opened this issue Jan 24, 2016 · 3 comments
Closed

Adding Google Play Music Support #31

cj-zeiger opened this issue Jan 24, 2016 · 3 comments

Comments

@cj-zeiger
Copy link

I've thrown together a prototype for google play music integration.

I was wondering if we could create a new feature branch so I could get some feedback and gauge interest?

@cj-zeiger
Copy link
Author

So I'm going to take that as a no then ...

@Twentysix26
Copy link
Member

Sorry for the late-ish answer.
I've taken a quick look at your fork and the library that it's using. Correct me if I'm wrong but it seems like it's based on urllib. Like I said in some other issues (see cleverbot) I can't put it in my bot, as it would make it non-responsive while it's being used. That's why I use aiohttp in my code (except for one function that it's still using requests).
So it would probably need some rewrite to integrate it in a async friendly way.

Also, I don't think I've ever got requests to support google play music before, people mostly ask for services like soundcloud, and I'd rather work on the most requested features.
Thanks for your interest in contributing

@cj-zeiger
Copy link
Author

True, I'm used to java threads where coroutines don't exist and threads can be paused on a line by line basis without needing to using anything like await.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants