Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use nanoid instead of randomstring #42

Open
Kayron013 opened this issue Feb 22, 2021 · 0 comments
Open

Use nanoid instead of randomstring #42

Kayron013 opened this issue Feb 22, 2021 · 0 comments
Assignees
@Kayron013
Labels
code quality Improvements to code quality, not functionality

Comments

@Kayron013
Copy link
Member

Use nanoid pkg instead of randomstring as it is a much smaller dependency.

zoomer-api/src/handlers/api/routes/meetings/handlers/createMeeting.ts

Lines 158 to 161 in 03f3b19

return randomString.generate({
length: 4,
charset: 'numeric',
});

@Kayron013 Kayron013 self-assigned this Feb 22, 2021
@Kayron013 Kayron013 added the code quality Improvements to code quality, not functionality label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kayron013 Kayron013

Labels
code quality Improvements to code quality, not functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kayron013