Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark identity() function for removal #1740

Open
GavinHuttley opened this issue Feb 24, 2024 · 3 comments
Open

mark identity() function for removal #1740

GavinHuttley opened this issue Feb 24, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@GavinHuttley
Copy link
Collaborator

What should be changed

cogent3.util.misc.identity()

Why

Not used in cogent3.

How much notice

6 months notice.

Guidelines for deprecation

Checking no internal uses will be tricky numpy and scipy also have functions called identity().

As this is a function that will be removed, see dev guidelines for deprecation of code. Indicate the limiting version (for when the old function will be removed) as .<PR month + x> where x is defined above.

@GavinHuttley GavinHuttley added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 24, 2024
@sharonli126
Copy link

I would like to do this issue

@GavinHuttley
Copy link
Collaborator Author

awesome! let me know if you run into any difficulties.

@sharonli126
Copy link

Hi Gavin, I have fixed the issue and synced the change. Please have a look. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants