Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new branch with sequence collections backend prototypes #1860

Open
3 tasks
GavinHuttley opened this issue May 10, 2024 · 2 comments
Open
3 tasks

Create new branch with sequence collections backend prototypes #1860

GavinHuttley opened this issue May 10, 2024 · 2 comments
Assignees
Labels
design API Design decisions enhancement New feature or request

Comments

@GavinHuttley
Copy link
Collaborator

GavinHuttley commented May 10, 2024

call the branch seq-collections-refactor

  • create src/cogent3/core/new_alignment.py put the classes and auxiliary functions for sequence data collections / views in there
  • create tests/test_core/test_new_alignment.py and put all the tests in there
  • change all your imports so the tests pass
@GavinHuttley GavinHuttley added enhancement New feature or request design API Design decisions labels May 10, 2024
@GavinHuttley GavinHuttley added this to the 2024 Q2 release milestone May 10, 2024
@fredjaya
Copy link
Contributor

fredjaya commented May 13, 2024

@GavinHuttley Branch is on my fork here https://github.com/fredjaya/cogent3/tree/seq-collections-refactor. Don't have permissions to add to the main repo though.

Noting that a lot of the WIP AlignedData methods were removed in the latest commits

@GavinHuttley
Copy link
Collaborator Author

thanks @fredjaya!

Can you make a PR from your repo to the new seq-collections-refactor branch I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design API Design decisions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants