Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command-timeout.lua: screenshot command doesn't print any OSD message #18

Closed
xfzv opened this issue Dec 29, 2022 · 3 comments
Closed

command-timeout.lua: screenshot command doesn't print any OSD message #18

xfzv opened this issue Dec 29, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@xfzv
Copy link

xfzv commented Dec 29, 2022

Describe the bug
Running script-message command-timeout ["screenshot"] 2 works but the OSD message (Screenshot - /path/to/screenshot) isn't printed, unlike when running screenshot.

To Reproduce

  1. Open any video file with $ mpv --no-really-quiet /path/to/video
  2. In mpv, open the console
  3. Run screenshot
  4. Screenshot - /path/to/screenshot, is displayed in the terminal, in mpv console and as an OSD message
  5. Run script-message command-timeout ["screenshot"] 2
  6. The screenshot message is only printed in the terminal and in mpv console, not in the OSD

Expected behaviour
script-message command-timeout ["screenshot"] 2 should behave like screenshot (the OSD message should be printed in mpv window)

Please complete the following information:

  • OS: Linux
  • mpv version: mpv 0.35.0
@xfzv xfzv added the bug Something isn't working label Dec 29, 2022
@CogentRedTester
Copy link
Owner

Add the osd-auto prefix before the screenshot command.

@CogentRedTester
Copy link
Owner

I highly suggest using delay-command.lua instead btw. delay-command has much simpler syntax and automatically adds osd-auto. The only reason to use command-timeout is if you want to be able to reset the timer when you send the command again.

@xfzv
Copy link
Author

xfzv commented Dec 30, 2022

Adding osd-auto works fine indeed.

I've just switched to delay-command.lua following your recommendation. All good!

Thanks.

@xfzv xfzv closed this as completed Dec 30, 2022
@CogentRedTester CogentRedTester added good first issue Good for newcomers and removed bug Something isn't working labels Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants