Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default UUID value unserializable as JSON #72

Closed
spieden opened this issue Apr 18, 2019 · 1 comment
Closed

Default UUID value unserializable as JSON #72

spieden opened this issue Apr 18, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@spieden
Copy link

spieden commented Apr 18, 2019

The FSx client is providing a default ClientRequestToken UUID value for my CreateFileSystem invocation, but the JSON serializer is choking on it with:

Exception Don't know how to write JSON of class java.util.UUID clojure.data.json/write-generic (json.clj:354)

Looking at the code every :idempotencyToken in a spec is receiving a default value in this manner.

Work-around for now is that I'm explicitly providing my own string UUID. Should the serializer have a dispatch for UUID values or should this be a string here:

https://github.com/cognitect-labs/aws-api/blob/master/src/cognitect/aws/util.clj#L250

@dchelimsky dchelimsky added the bug Something isn't working label Apr 19, 2019
@dchelimsky dchelimsky added this to TODO in AWS API Project Apr 19, 2019
@dchelimsky dchelimsky moved this from TODO to In progress in AWS API Project Apr 19, 2019
@dchelimsky dchelimsky moved this from In progress to Ready to release in AWS API Project Apr 19, 2019
@spieden
Copy link
Author

spieden commented Apr 19, 2019

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
AWS API Project
  
Ready to release
Development

No branches or pull requests

2 participants