Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move timeseries out of the queryTarget object #36

Closed
hulien22 opened this issue Feb 26, 2019 · 2 comments
Closed

Move timeseries out of the queryTarget object #36

hulien22 opened this issue Feb 26, 2019 · 2 comments
Assignees

Comments

@hulien22
Copy link
Contributor

We currently store all timeseries rooted at an asset in the QueryTarget object. This was fine as that object was only really visible through the JSON section. However, it really should not be there as that object should just be for properties that remain constant between reloads of the page (ie not for storage)

Grafana 6.0.0 also introduces the explore section, which puts the querytarget object in the url, and this can cause issues if we try to store a lot of timeseries.

@hulien22 hulien22 self-assigned this Feb 26, 2019
@hulien22
Copy link
Contributor Author

I forgot that we do actually require the timeseries array for 'Select Timeseries from Asset' so we can't completely remove it...
We may want to look into only storing whether or not a timeseries is selected in the QueryTarget object, that way we can still reduce its size.

@hulien22
Copy link
Contributor Author

We now only keep the timeseries array for 'Select Timeseries from Asset' and no longer in 'Custom Query', and also limit the size of that array. This has been fixed to the point that explore is usable and the QueryTarget object is smaller, so I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant