Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: values aggregates for events #377

Merged
merged 2 commits into from Jun 23, 2020
Merged

feat: values aggregates for events #377

merged 2 commits into from Jun 23, 2020

Conversation

BugGambit
Copy link
Contributor

No description provided.

@BugGambit BugGambit requested review from polomani, ponnapz, mrtraser and a team June 22, 2020 12:45
@BugGambit BugGambit self-assigned this Jun 22, 2020
src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #377 into v1 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v1     #377   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files          54       54           
  Lines        1652     1654    +2     
  Branches      185      185           
=======================================
+ Hits         1586     1588    +2     
  Misses         64       64           
  Partials        2        2           
Impacted Files Coverage Δ
src/types/types.ts 100.00% <ø> (ø)
src/resources/events/eventsApi.ts 100.00% <100.00%> (ø)

Copy link
Contributor Author

@BugGambit BugGambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting @ponnapz api change for this one to pass the CI and be merged

@polomani
Copy link
Collaborator

#378
maybe it doesn't defend my argument about generated sdks, but still needs your opinion

@polomani
Copy link
Collaborator

I closed that alternative pr.
I think we should change it to client.events.aggregate.uniqueValues(...) when we do a breaking change

Copy link
Collaborator

@polomani polomani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to remove aliases, other than that looks good

src/types/types.ts Outdated Show resolved Hide resolved
src/types/types.ts Outdated Show resolved Hide resolved
@polomani
Copy link
Collaborator

when squash
feat(events): unique values aggregate

@polomani polomani merged commit d47152c into v1 Jun 23, 2020
@polomani polomani deleted the f1/values_aggregate branch June 23, 2020 11:04
cognite-cicd pushed a commit that referenced this pull request Jun 23, 2020
# [2.31.0](v2.30.0...v2.31.0) (2020-06-23)

### Features

* **events:** unique values aggregate ([#377](#377)) ([d47152c](d47152c))
@cognite-cicd
Copy link
Contributor

🎉 This PR is included in version 2.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

BugGambit added a commit that referenced this pull request Jun 23, 2020
BugGambit pushed a commit that referenced this pull request Jun 23, 2020
# [2.31.0](v2.30.0...v2.31.0) (2020-06-23)

### Features

* **events:** unique values aggregate ([#377](#377)) ([d47152c](d47152c))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants