Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing properties to update 3d models #718

Merged
merged 2 commits into from Nov 19, 2021

Conversation

j-bjorne
Copy link
Contributor

Attempt to add update to model3d according to documentation

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #718 (23790e3) into master (de3557f) will increase coverage by 1.02%.
The diff coverage is 80.28%.

@@            Coverage Diff             @@
##           master     #718      +/-   ##
==========================================
+ Coverage   84.06%   85.09%   +1.02%     
==========================================
  Files          70       85      +15     
  Lines        1952     2523     +571     
  Branches      249      332      +83     
==========================================
+ Hits         1641     2147     +506     
- Misses        301      362      +61     
- Partials       10       14       +4     
Impacted Files Coverage Δ
packages/beta/src/cogniteClient.ts 100.00% <ø> (ø)
packages/core/src/testUtils.ts 35.59% <0.00%> (-19.58%) ⬇️
...stable/src/api/entityMatching/entityMatchingApi.ts 37.14% <ø> (ø)
packages/stable/src/retryValidator.ts 100.00% <ø> (ø)
packages/stable/src/api/3d/assetMappings3DApi.ts 79.16% <16.66%> (-20.84%) ⬇️
packages/stable/src/api/3d/nodes3DApi.ts 81.81% <20.00%> (-18.19%) ⬇️
packages/stable/src/api/projects/projectsApi.ts 78.94% <20.00%> (-21.06%) ⬇️
packages/core/src/baseResourceApi.ts 34.00% <25.00%> (-5.07%) ⬇️
...s/playground/src/api/functions/functionCallsApi.ts 29.62% <29.62%> (ø)
packages/stable/src/api/3d/revisions3DApi.ts 95.65% <33.33%> (-4.35%) ⬇️
... and 84 more

@j-bjorne j-bjorne merged commit 516fb20 into master Nov 19, 2021
@j-bjorne j-bjorne deleted the fix-3d-update-request branch November 19, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants