Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following Gulp Plugin Guidlines #1

Open
1 of 4 tasks
cognitom opened this issue Jun 9, 2014 · 3 comments
Open
1 of 4 tasks

Following Gulp Plugin Guidlines #1

cognitom opened this issue Jun 9, 2014 · 3 comments

Comments

@cognitom
Copy link
Owner

cognitom commented Jun 9, 2014

  • Read buffer instead of direct file access
  • Use temp to avoid conflict
  • Divide this module into two, and make a new node-sketch module
  • Ask to remove it from the blacklist

There is a limitation of vinyl-fs. The plugin couldn't read a directory. This causes a problem if a plugin works with OSX packages or directories. Some research about it is needed. After ver. 3.1, Sketch file is just a file.

@cognitom
Copy link
Owner Author

cognitom commented Jul 6, 2014

The code has been changed to use temporary just because of the async support.

@cognitom
Copy link
Owner Author

Good move!

we’re switching back to a single-file document format
http://mail.sketchplugins.com/pipermail/dev_sketchplugins.com/2014-August/000592.html

@cognitom
Copy link
Owner Author

gulp-sketch has already updated to support single-file format #7 . But, sketchtool seems to not support standard input or dev/stdin.

@cognitom cognitom changed the title Support parallel run Following Gulp Plugin Guidlines Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant