Initial change from dicts to objects #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kipply
reviewed
May 4, 2021
cohere/__init__.py
Outdated
| @@ -96,3 +96,24 @@ def __repr__(self): | |||
| self.message, | |||
| self.http_status, | |||
| ) | |||
|
|
|||
| class CohereGenerate: | |||
There was a problem hiding this comment.
how do these show up in debugging / errors? Sholud they just be Generation or CohereGeneration?
There was a problem hiding this comment.
took a look at twillo sdk and i think we should go with Generate. I'm going with the docs naming right now, so it won't be Generation.
There was a problem hiding this comment.
yeah the docs name the endpoint as Generate, however the product is a Generation. Its the same reason an endpoint called Create🍌 would return a 🍌 and not a Create🍌
There was a problem hiding this comment.
it'll be hard to come up with a name for choosebest 🤔
kipply
reviewed
May 4, 2021
kipply
reviewed
May 4, 2021
|
update the sanity test file as well? make sure everything runs |
kipply
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know about how we should name objects yet.
Originally, I wanted to have one "catch all" CohereResponse object, but the names were confusing because we had "likelihood" and "likelihoods", thus designing it this way.
This should also be refactored into bzz and docs
closes #8