Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dark mode / light mode switch #54

Open
petrvecera opened this issue Aug 1, 2021 · 2 comments
Open

Enable dark mode / light mode switch #54

petrvecera opened this issue Aug 1, 2021 · 2 comments
Labels
enhancement New feature or request feature request Feature request

Comments

@petrvecera
Copy link
Member

petrvecera commented Aug 1, 2021

We could try to add dark mode, there could be a switch in top right corner

https://ant.design/docs/react/customize-theme#Official-Themes-%F0%9F%8C%88

If anyone wants to help with this: I am looking mostly for POC how to nicely swap the themes for both antd and our components.

My POC requires taking out .css files for antd. Which is not very efficient or elegant. Would require to manually do this on every antd update. Could be probably automated with the webpack ?

After adding this we need to verify that all components are displayed correctly.
We could have localstorage where persons preference would be stored.

@petrvecera petrvecera added enhancement New feature or request feature request Feature request labels Aug 1, 2021
@thenicekat
Copy link
Contributor

No offence, just a suggestion but you can use styled components to implement that easily something like the top right corner on my portfolio
https://divyateja04.github.io

@petrvecera
Copy link
Member Author

Styled components is a framework to more easily style your specific component. This task is little bit more complicated. We are not building our styling. Most of the components on the site are using default styles from antd component library. Which already provides dark theme.

Building dark theme on our own would be extremely hard job given the components we have. It could definitely help with the components we have for charts maybe - or any other component where we specified our colors / our styling. But this is just fraction of components in compare what we are utilizing from the antd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants