This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
Issue-249 Visualize videos OT-496 #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the warning level as both Android and iOS implemented the native parts: coi-dev/flutter-deltachat-core@b88f4eb |
|
Re-added the warning label as it seems that some file formats are not well handled (no preview is generated). @florianhaar please update this ticket as soon as you have more information. If all issues are fixed please remove the warning label and ping me. |
Boehrsi
added a commit
that referenced
this pull request
Nov 26, 2019
|
As the core is already merged, but this PR needs some adjustments, I added 4092eb8 as temporary fix. This fix should get removed as soon as this PR is merged. |
phranck
approved these changes
Nov 26, 2019
Boehrsi
reviewed
Nov 26, 2019
Boehrsi
reviewed
Nov 26, 2019
Boehrsi
reviewed
Nov 26, 2019
|
No change request, just some comments and potentially stuff for a followup ticket. |
florianhaar
force-pushed
the
Issue-249_VisualizeVideos
branch
from
f20bd8a
to
da49c93
Compare
|
Moved the loading logic to the MessageAttachmentBloc |
CihanOezkan
approved these changes
Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the given issue
#249
Describe what the problem was / what the new feature is
Videos were shown as generic attachments and it was not possible to see what a video is.
Describe your solution
Added a method to create a thumbnail of the video and show the duration on the image. A play icon shows that the image is a video.
Additional context
Add method to set and get the duration. flutter-deltachat-core#63