Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ownership of layers.conf file #56

Closed
Bejusek opened this issue Feb 5, 2016 · 3 comments
Closed

Fix ownership of layers.conf file #56

Bejusek opened this issue Feb 5, 2016 · 3 comments
Assignees

Comments

@Bejusek
Copy link
Collaborator

Bejusek commented Feb 5, 2016

Right now the following code in internal/module/registerlayer.pp class creates layers.conf file as root.

exec { "jboss::module::layer::${layer}":
  command => "/bin/awk -F'=' 'BEGIN {ins = 0} /^layers=/ { ins = ins + 1; print \$1=${layer},\$2 } END {if(ins == 0) print \"layers=${layer},base\"}' > ${jboss::home}/modules/layers.conf",
  unless  => "/bin/egrep -e '^layers=.*${layer}.*' ${jboss::home}/modules/layers.conf",
  require => Anchor['jboss::installed'],
  notify  => Service[$jboss::product],
}

On systems with umask other than default 0022, this file may become unreadable by jboss::jboss_user, thus preventing jboss service from starting.

This command should be executed as $jboss::jboss_user

@Cosaquee Cosaquee added this to the v1.0.4 - WildOpal milestone Feb 5, 2016
@Cosaquee
Copy link
Contributor

Cosaquee commented Feb 5, 2016

@Bejusek can you do this or some other team member should fix this ?

@Bejusek Bejusek self-assigned this Feb 5, 2016
@Bejusek
Copy link
Collaborator Author

Bejusek commented Feb 5, 2016

Sure, I'll fix it.

@Bejusek
Copy link
Collaborator Author

Bejusek commented Feb 25, 2016

Fixed by merging #57

@cardil cardil modified the milestones: v1.0.4 - WildOpal, v1.1.0 - RiverBlue Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants