Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncImagePainter doesn't render if used with Icon. #901

Closed
colinrtwhite opened this issue Sep 22, 2021 · 3 comments
Closed

AsyncImagePainter doesn't render if used with Icon. #901

colinrtwhite opened this issue Sep 22, 2021 · 3 comments
Labels
help wanted Issues that are up for grabs + are good candidates for community PRs

Comments

@colinrtwhite
Copy link
Member

Describe the bug
rememberImagePainter won't render anything if used with Icon from androidx.compose.material:1.0.2.

Expected behavior
rememberImagePainter should work with Icon (and anywhere a standard Painter is used).

To Reproduce
Change the test in ImagePainterTest.basicLoad_http to use an Icon instead of an Image.

Version
1.3.2
@colinrtwhite colinrtwhite added the bug Something isn't working label Sep 22, 2021
@colinrtwhite colinrtwhite added the help wanted Issues that are up for grabs + are good candidates for community PRs label Oct 6, 2021
@colinrtwhite colinrtwhite removed the bug Something isn't working label Nov 16, 2021
@cemore2048
Copy link
Collaborator

@colinrtwhite I'll take a look at this one if you haven't already

@colinrtwhite
Copy link
Member Author

colinrtwhite commented Nov 22, 2021 •
edited

@cemore2048 I haven't - sounds good, thanks!

@colinrtwhite colinrtwhite mentioned this issue Mar 7, 2022
Closed
@colinrtwhite colinrtwhite changed the title ImagePainter doesn't render if used with Icon. AsyncImagePainter doesn't render if used with Icon. May 30, 2022
@colinrtwhite
Copy link
Member Author

Looked into this and it appears to be fixed in Coil 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues that are up for grabs + are good candidates for community PRs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cemore2048 @colinrtwhite