Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store memory profile plots, show them when hovering over memory usage dashboard? #268

Open
gjoseph92 opened this issue Aug 19, 2022 · 1 comment
Labels
dx Developer experience enhancement New feature or request

Comments

@gjoseph92
Copy link
Contributor

I wonder if we could store plots from the memory profiler as static assets (PNGs) somewhere for every test run. Combined with #267 and a more predictable naming scheme, we then could have the tooltip for the profiles show the memory profile of that test run when you hover over the mark, just as an <img>. (This might require some altair hackiness, but I'm sure @ian-r-rose can figure it out.)

I think this would be useful both when:

  1. You're iterating on a new test and want to see more detail about what's going on. Having the memory plots automatically saved (even to the local filesystem) might be helpful.
  2. A memory regression occurs. Being able to compare the memory timeseries before and after the regression could be helpful to get a guess at what's going on. Does it look the same, just shifted up? Or is it spikier, etc.?

This isn't top priority, just something that might be useful in the future.

@crusaderky
Copy link
Contributor

crusaderky commented Sep 8, 2022

I'd rather store them as pickles or yaml - this would make it, for example, very easy to overlap the data from multiple runs into a single plot.
We could also migrate MemorySampler from matplotlib to altair - probably won't need a deprecation cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Developer experience enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants