Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CI failed ⚠️ #272

Closed
github-actions bot opened this issue Aug 21, 2022 · 4 comments
Closed

⚠️ CI failed ⚠️ #272

github-actions bot opened this issue Aug 21, 2022 · 4 comments
Labels
ci-failure h2o-benchmark work related to h2o benchmark regression

Comments

@github-actions
Copy link

Workflow Run URL

@fjetter fjetter added the h2o-benchmark work related to h2o benchmark label Aug 22, 2022
@fjetter
Copy link
Member

fjetter commented Aug 22, 2022

This is due to a detected regression

    raise Exception(
Exception:  Regressions detected 1: 
runtime = 'coiled-upstream-py3.9', name = 'test_q3[5 GB (parquet)]', category = 'benchmarks', last_three_duration [s] = (80.41926574707031, 78.423574924469, 79.43234944343567), duration_threshold [s] = 78.3170660380969 

image

image

Not entirely convinced this should count as a regression

@jrbourbeau
Copy link
Member

xref #270

@ncclementi
Copy link
Contributor

The average now shows a smaller difference, but few days ago, this poped up in regressions as
runtime = 'coiled-upstream-py3.9', name = 'test_q3[5 GB (parquet)]', category = 'benchmarks', last_three_duration [s] = (78.423574924469, 79.43234944343567, 78.1142942905426), duration_threshold [s] = 74.33889042616087

That is a bigger jump. I'm not sure it's not a regression.

As more runs get added the average will hide a potential regression. @jrbourbeau I agree we need to revisit the logic, but in this case, I can see a jump on right after Wednesday 17 and it is sustained. I noticed this in #271 .

Thoughts?

@ncclementi
Copy link
Contributor

Closing in favor of #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-failure h2o-benchmark work related to h2o benchmark regression
Projects
None yet
Development

No branches or pull requests

3 participants