Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang data streaming API - Requesting volume data closes connection with error 1006 #110

Closed
marvin-hansen opened this issue Jul 7, 2021 · 3 comments
Assignees
Labels

Comments

@marvin-hansen
Copy link
Contributor

Issue related to PR #108

Requesting data streams using Golang works for all message types except volume data. When constructing a hello message requesting only volume data, the connection terminates with error 1006. It is unclear to me why all other data types work as expected while requesting volume continues to throw that error. I am still investigation this error, but any help to fix this would be apricated.

An isolated test replicating this issue is part of the PR.
#108

@Svisstack
Copy link
Contributor

@marvin-hansen Can you provide exact hello message that producing this behavior in json here?

@Svisstack Svisstack self-assigned this Jul 7, 2021
@Svisstack Svisstack added the bug label Jul 7, 2021
@marvin-hansen
Copy link
Contributor Author

@Svisstack Thank you,

I spent some time on the Sandy Console and eventually found the mistake. Essentially, for volume only the AssetID must be submitted but I was sending the SymbolID, which then caused the error.

However, I think there should be a request validation in the API i.e. if volume gets requested using a hello message without AssetID, then return an error message and terminate then. Would be nice to get such an error.

However, I patch the code base and re-submit the PR.

Thank you

Svisstack pushed a commit that referenced this issue Jul 9, 2021
* Added go-ws web streaming SDK.

* Added missing go.sum

* Updated Readme for go-ws

* Renamed Reconnect to ResetConnection to reflect intent!

* Applied fix for Issue #110

* Updated sample code

* Removed test covering volume bug

* Updated code comment.
@Svisstack
Copy link
Contributor

We fixed that issue.

Svisstack pushed a commit that referenced this issue Mar 30, 2024
* Added go-ws web streaming SDK.

* Added missing go.sum

* Updated Readme for go-ws

* Renamed Reconnect to ResetConnection to reflect intent!

* Applied fix for Issue #110

* Updated sample code

* Removed test covering volume bug

* Updated code comment.
Svisstack pushed a commit that referenced this issue Mar 30, 2024
* Added go-ws web streaming SDK.

* Added missing go.sum

* Updated Readme for go-ws

* Renamed Reconnect to ResetConnection to reflect intent!

* Applied fix for Issue #110

* Updated sample code

* Removed test covering volume bug

* Updated code comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants