Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Canceling all orders does not cancel stop order #25

Closed
petercerno opened this issue Dec 30, 2016 · 12 comments
Closed

Canceling all orders does not cancel stop order #25

petercerno opened this issue Dec 30, 2016 · 12 comments

Comments

@petercerno
Copy link

When I call cancelOrders (or cancelAllOrders) from an AuthenticatedClient, it returns 0 cancelled orders even though I have one active buy-stop order on the BTC-EUR product.
Calling cancelOrder with the correct orderID works fine, although from time-to-time also this method fails with the status code: 400.

@loriopatrick
Copy link

loriopatrick commented Jan 1, 2017

Unfortunately named, cancelAllOrders only cancels all open orders. Stop orders after placed have an active status. It may be worth it to rename cancelAllOrders to cancelOpenOrders. @mihar thoughts?

@JThobbyist
Copy link

I am experiencing this problem too

@aamazie
Copy link

aamazie commented Apr 18, 2018

I've been waiting for an extraordinarily long time to figure out how to do this. Does anyone have any idea?

@JThobbyist
Copy link

JThobbyist commented Apr 18, 2018 via email

@aamazie
Copy link

aamazie commented Apr 18, 2018

When I request get orders, I just get a [200] confirmation response, which I assume means there aren't any "open" orders but that the call went through.

@JThobbyist
Copy link

JThobbyist commented Apr 19, 2018 via email

@JThobbyist
Copy link

e26de575-3db8-4ee7-b88b-982f10eef86e

@JThobbyist
Copy link

(I use fibers and futures to make my code run synchronously when I need it to)

@aamazie
Copy link

aamazie commented Apr 19, 2018

With Python I'm running print(requests.get(api_url + "orders", auth=auth)) and getting a [200]. getOrders() doesn't work. I assume that's JavaScript and I'm not totally sure what to do with that currently unless I can JSONify something somehow

@JThobbyist
Copy link

JThobbyist commented Apr 19, 2018 via email

@aamazie
Copy link

aamazie commented Apr 19, 2018

Ah. So it is. Well thanks @JThobbyist for showing me that at least it's possible :)

@rmm5t rmm5t closed this as completed in 715dda4 Jun 25, 2018
@rmm5t
Copy link
Contributor

rmm5t commented Jun 25, 2018

While I agree that this method is named somewhat unfortunately, the API reference names it the same and also documents it as only canceling open orders.
https://docs.gdax.com/#cancel-all

However, I did add some additional information to the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

5 participants