Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Rename gdax to coinbase pro #346

Merged
merged 7 commits into from Nov 3, 2018
Merged

Rename gdax to coinbase pro #346

merged 7 commits into from Nov 3, 2018

Conversation

blair
Copy link
Contributor

@blair blair commented Oct 27, 2018

A bunch of small commits to switch from GDAX to Coinbase Pro. I chose Coinbase Pro since it looks like it would be more popular than Coinbase Prime for users of this module.

$ perl -w -p -i -e 's#https://docs\.gdax\.com#https://docs.pro.coinbase.com#g' *

Pick docs.pro.coinbase.com instead of docs.prime.coinbase.com because
this module is much more likely to be used by individual developers
rather than financial institutions [1].

[1] https://support.pro.coinbase.com/customer/en/portal/articles/2945306-what-is-the-difference-between-pro-and-prime-
See https://docs.pro.coinbase.com/#websocket-feed for the URL.

$ perl -w -p -i -e 's#wss://ws-feed\.gdax\.com#wss://ws-feed.pro.coinbase.com#g' * */* */*/*
…ro URL.

See https://docs.pro.coinbase.com/#sandbox-urls for the URL.

perl -w -p -i -e 's#wss://ws-feed-public\.sandbox\.gdax\.com#wss://ws-feed-public.sandbox.pro.coinbase.com#g' * */* */*/*
@fb55 fb55 merged commit 8bdd1cc into coinbase:master Nov 3, 2018
@fb55
Copy link
Contributor

fb55 commented Nov 3, 2018

Thanks so much for this!

@blair blair deleted the rename-gdax-to-coinbase-pro branch November 3, 2018 01:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants