Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new release #449

Closed
rllola opened this issue Oct 11, 2022 · 6 comments
Closed

Create a new release #449

rllola opened this issue Oct 11, 2022 · 6 comments

Comments

@rllola
Copy link

rllola commented Oct 11, 2022

Would it be possible to create a new release with the latest commit ? It looks like it is required for Rosetta CLI to pass the check:spec.

The commit required : e03849b

@GeekArthur
Copy link
Contributor

Yes, we will create releases for both Rosetta CLI and Rosetta SDK soon, usually the releases will be created monthly

@rllola
Copy link
Author

rllola commented Oct 12, 2022

Hey @GeekArthur

I noticed in Rosetta CLI you added the check when no hash or index are specified in the partial block identifier. However because Rosetta CLI is using rosetta-sdk-go v0.8.1 it doesn't include the commit e03849b

Because of that check:spec will always fail.

see the piece of code in v0.10.0
https://github.com/coinbase/rosetta-cli/blob/v0.10.0/cmd/check_spec.go#L306-L313

A release for rosetta-sdk-go and updating it in rosetta cli will fix it. Do you think it would be possible to make an early release just to fix that ? It would avoid us having to have our own fork until it is fixed.

@GeekArthur
Copy link
Contributor

@rllola You are correct, the current rosetta-cli 0.10.0 doesn't consume the latest rosetta-sdk-go which includes the check:spec fix. Given currently check:spec is not the mandatory requirement of rosetta implementation, so I didn't create the releases for both rosetta-cli and rosetta-sdk-go immediately to accommodate the release schedule for other features/fixes, but I will wait for 2 more days, if nothing else needs to deliver I will create a patch release this Friday only for check:spec fix

@rllola
Copy link
Author

rllola commented Nov 15, 2022

@GeekArthur Any news about the release ?

@tac0turtle
Copy link

pinging about this, it would help us avoid a replace tag in our and our users go.mods

@GeekArthur
Copy link
Contributor

Release v0.8.2 is published

@rllola rllola closed this as completed Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants