fix: useCache() with indexes but no entities ever stored (#279)

reactive · Mar 1, 2020 · 67a1257 · 67a1257
1 parent af77661
commit 67a1257
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/rest-hooks/src/state/selectors/__tests__/buildInferredResults.ts b/packages/rest-hooks/src/state/selectors/__tests__/buildInferredResults.ts
@@ -148,4 +148,19 @@ describe('buildInferredResults()', () => {
       data: undefined,
     });
   });
+
+  it('should work with indexes but no indexes stored', () => {
+    const schema = {
+      pagination: { next: '', previous: '' },
+      data: IndexedUserResource.asSchema(),
+    };
+    expect(buildInferredResults(schema, { username: 'bob' }, {})).toEqual({
+      pagination: { next: '', previous: '' },
+      data: undefined,
+    });
+    expect(buildInferredResults(schema, { hover: 'bob' }, {})).toEqual({
+      pagination: { next: '', previous: '' },
+      data: undefined,
+    });
+  });
 });
diff --git a/packages/rest-hooks/src/state/selectors/buildInferredResults.ts b/packages/rest-hooks/src/state/selectors/buildInferredResults.ts
@@ -24,7 +24,7 @@ export default function buildInferredResults<
     if (id !== undefined && id !== '') return id as any;
     // now attempt lookup in indexes
     const indexName = indexFromParams(params, schema.indexes);
-    if (indexName) {
+    if (indexName && indexes[schema.key]) {
       // 'as Record<string, any>': indexName can only be found if params is a string key'd object
       return indexes[schema.key][indexName][
         (params as Record<string, any>)[indexName]