Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Polling subscriptions handle offline/online #227

Merged
merged 1 commit into from Jan 5, 2020

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jan 5, 2020

Motivation

Fetching while offline is not only wasteful, it will result in a perfectly working website turning into network errors.

Solution

  • Listen to online/offline events.
  • When going online immediately dispatch a fetch.

@ntucker ntucker merged commit 38c9bc6 into master Jan 5, 2020
@ntucker ntucker deleted the polling-offline branch January 5, 2020 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant