Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Commonjs bundle uses native-compatible code #263

Merged
merged 1 commit into from Feb 10, 2020
Merged

enhance: Commonjs bundle uses native-compatible code #263

merged 1 commit into from Feb 10, 2020

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Feb 10, 2020 •
edited

Motivation

Often metro bundler for react-native will use the common js version - so lets ensure it's maximum compatibility.

Solution

Read .native.ts extensions first for module resolution in CJS bundling

@ntucker ntucker merged commit 5da9047 into master Feb 10, 2020
@ntucker ntucker deleted the native-fetch branch February 10, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ntucker