Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 0 for expiryLength should not result in default #296

Merged
merged 1 commit into from Mar 13, 2020

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Mar 13, 2020

Fixes #294

Motivation

This would be rather confusing.

Solution

Also throw error in dev mode for any negative values as that would make no sense.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2020

Size Change: +91 B (0%)

Total Size: 29.3 kB

Filename Size Change
packages/rest-hooks/dist/index.cjs.js 16.1 kB +83 B (0%)
packages/rest-hooks/dist/index.umd.min.js 6.74 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/legacy/dist/index.cjs.js 424 B 0 B
packages/legacy/dist/index.umd.min.js 376 B 0 B
packages/normalizr/dist/normalizr.es.min.js 2.17 kB 0 B
packages/test/dist/index.cjs.js 1.84 kB 0 B
packages/use-enhanced-reducer/dist/index.cjs.js 1.08 kB 0 B
packages/use-enhanced-reducer/dist/index.umd.min.js 593 B 0 B

compressed-size-action

@ntucker ntucker merged commit c75dca5 into master Mar 13, 2020
@ntucker ntucker deleted the dataExpiryLength branch March 13, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truthy issues with FetchOptions
1 participant