enhance: useCache() and useStatefulResource() respect invalidIfStale #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: When invalidIfStale is true, useCache() and
useStatefulResource() will no longer return entities, even if they
are in the cache
Motivation
invalidIfStale
was added, and its behavior affected suspense, which is the primary mechanism to use data. However, as other use cases expanded it became clear that equivalent behavior should be reflected in the other hooks. This is especially important when not using suspense at all - for instance whenuseStatefulResource()
.Solution
This only changes behavior when invalidIfStale is true.
In this case, we should consider the same case where useResource() would suspend and return 'empty' results. This is key for replicating the same behaviors and patterns with both
useCache()
anduseStatefulResource()
.