Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rename action.meta.url to 'key' #325

Merged
merged 1 commit into from Apr 26, 2020
Merged

enhance: Rename action.meta.url to 'key' #325

merged 1 commit into from Apr 26, 2020

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 26, 2020

BREAKING CHANGE: url -> key on all action.meta
Testing lib now relies on new export in rest-hooks 5

Motivation

'url' has long be an inaccurate description. This is the fetch key.

Solution

  • url -> key on all action.meta
  • Also made testing lib rely on rest hooks exports to make it better future compatible

BREAKING CHANGE: url -> key on all action.meta
Testing lib now relies on new export in rest-hooks 5
@github-actions
Copy link
Contributor

Size Change: -20 B (0%)

Total Size: 26.8 kB

Filename Size Change
packages/rest-hooks/dist/index.cjs.js 15.5 kB -3 B (0%)
packages/rest-hooks/dist/index.umd.min.js 6.98 kB -6 B (0%)
packages/test/dist/index.cjs.js 1.88 kB -11 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/legacy/dist/index.cjs.js 433 B 0 B
packages/legacy/dist/index.umd.min.js 376 B 0 B
packages/use-enhanced-reducer/dist/index.cjs.js 1.08 kB 0 B
packages/use-enhanced-reducer/dist/index.umd.min.js 593 B 0 B

compressed-size-action

@ntucker ntucker merged commit 5a06fe4 into master Apr 26, 2020
@ntucker ntucker deleted the action-url branch April 26, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant