Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: State updates from mutate/read now the same #326

Merged
merged 1 commit into from Apr 26, 2020

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Apr 26, 2020

BREAKING CHANGE: Mutation fetches now result in:

  • meta entries
  • results entries

Motivation

Previously fetch keys were simply urls (pre 1.0), so a distinction was needed between mutate and read types. However, for some time now these have serialized to their own unique value. This is the first stage for heavily simplifying the codepaths.

Solution

This means mutates now result in new entries in the state: meta, results. This is likely valuable in some cases.

Open questions

Future path to unify deletes as well?

BREAKING CHANGE: Mutation fetches now result in:
- meta entries
- results entries
@github-actions
Copy link
Contributor

Size Change: -121 B (0%)

Total Size: 26.7 kB

Filename Size Change
packages/rest-hooks/dist/index.cjs.js 15.4 kB -67 B (0%)
packages/rest-hooks/dist/index.umd.min.js 6.92 kB -54 B (0%)
ℹ️ View Unchanged
Filename Size Change
packages/legacy/dist/index.cjs.js 433 B 0 B
packages/legacy/dist/index.umd.min.js 376 B 0 B
packages/test/dist/index.cjs.js 1.88 kB 0 B
packages/use-enhanced-reducer/dist/index.cjs.js 1.08 kB 0 B
packages/use-enhanced-reducer/dist/index.umd.min.js 593 B 0 B

compressed-size-action

@ntucker ntucker merged commit c789dfb into master Apr 26, 2020
@ntucker ntucker deleted the mutate-read-same branch April 26, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant