Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Services] Add versioning info #11

Merged
merged 2 commits into from
Sep 21, 2020
Merged

[Services] Add versioning info #11

merged 2 commits into from
Sep 21, 2020

Conversation

patrick-ogrady
Copy link
Contributor

This PR updates the versioning info in the /network/options response to be correct.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 133

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 69.915%
Files with Coverage Reduction New Missed Lines %
indexer/indexer.go 2 75.17%
Totals Coverage Status
Change from base Build 102: -0.08%
Covered Lines: 1406
Relevant Lines: 2011
💛 - Coveralls

@patrick-ogrady patrick-ogrady merged commit ba9d9ce into master Sep 21, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/add-versioning-info branch September 21, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

@cindyxkuang cindyxkuang Awaiting requested review from cindyxkuang

@juliankoh juliankoh Awaiting requested review from juliankoh

@qiwu7 qiwu7 Awaiting requested review from qiwu7

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrick-ogrady @coveralls @annieke