Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log system issue #272

Closed
GeekArthur opened this issue Jan 25, 2022 · 2 comments
Closed

Log system issue #272

GeekArthur opened this issue Jan 25, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@GeekArthur
Copy link
Contributor

GeekArthur commented Jan 25, 2022

Describe the bug
Seems like we hardcode the error message instead of using the return err -> Return error message is Account.Address is missing, but the actual error message is Account.SubAccount.Address is missing
Screen Shot 2022-01-25 at 12 25 08 PM

If this is a generic issue, we need to address all of them.

To Reproduce
Run rosetta-cli and modify the config.json to ensure it hit the line as the screenshot shows

Expected behavior
We need to wrap the err in the error message then return

@GeekArthur GeekArthur added the bug Something isn't working label Jan 25, 2022
@shrimalmadhur
Copy link
Contributor

Thanks @GeekArthur for raising the issue. We could definitely wrap the internal error and keep the hardcoded one too so that we have a generic message plus the actual error. Feel free to contribute and wrap the internal error.

@shrimalmadhur shrimalmadhur added the good first issue Good for newcomers label Jan 25, 2022
@GeekArthur
Copy link
Contributor Author

It's fixed in new error handling mechanism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Development

No branches or pull requests

2 participants