Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple End Conditions #106

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 12, 2020

Related PR: #103

Success

{
 "error": "",
 "end_condition": {
  "type": "Duration End Condition",
  "detail": "Seconds: 30"
 },
 "tests": {
  "request_response": true,
  "response_assertion": true,
  "block_syncing": true,
  "balance_tracking": true,
  "reconciliation": true
 },
 "stats": {
  "blocks": 4409,
  "orphans": 0,
  "transactions": 431,
  "operations": 1123,
  "active_reconciliations": 514,
  "inactive_reconciliations": 216,
  "reconciliation_coverage": 1
 }
}

Error

Without Stats

{
 "error": "retries exhausted: unable to fetch network list: unable to initialize asserter",
 "end_condition": null,
 "tests": {
  "request_response": false,
  "response_assertion": true,
  "block_syncing": null,
  "balance_tracking": null,
  "reconciliation": null
 },
 "stats": null
}

With Stats

{
 "error": "negative balance -2092283817431135770:\u0026{Symbol:FAUX Decimals:8 Metadata:map[]} for \u0026{Address:TJffRCrGOxJFnMN3i0EL6ekuj1She9TJ SubAccount:\u003cnil\u003e Metadata:map[]} at \u0026{Index:1 Hash:BX5RmpEwNOXfFp4oQbZl1i3X4HnvCrXK}: unable to add block to storage BX5RmpEwNOXfFp4oQbZl1i3X4HnvCrXK:1: unable to process block: unable to process blocks: unable to sync to 163",
 "end_condition": null,
 "tests": {
  "request_response": true,
  "response_assertion": true,
  "block_syncing": true,
  "balance_tracking": false,
  "reconciliation": null
 },
 "stats": {
  "blocks": 1,
  "orphans": 0,
  "transactions": 0,
  "operations": 0,
  "active_reconciliations": 0,
  "inactive_reconciliations": 0,
  "reconciliation_coverage": 0
 }
}

Changes

  • Return EndCondition in CheckDataResults
  • never omit empty for test results
  • Allow multiple end conditions to be active

@coveralls
Copy link

coveralls commented Aug 12, 2020

Pull Request Test Coverage Report for Build 3737

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 71.559%

Totals Coverage Status
Change from base Build 3704: -0.06%
Covered Lines: 1721
Relevant Lines: 2405

💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title CheckDataResults includes end condition Allow Multiple End Conditions Aug 12, 2020
Signed-off-by: Patrick O'Grady <prohb125@gmail.com>
@patrick-ogrady patrick-ogrady requested review from yfl92 and a team August 12, 2020 23:34
Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-ogrady patrick-ogrady merged commit bb3677b into master Aug 13, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/output-exit-condition branch August 13, 2020 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants