Mark the bootstrapped accounts as "seen". #340
Conversation
|
@andreibancioiu are you able to test this change locally and verify it's working and not impact existing workflow? |
| @@ -218,6 +218,17 @@ func InitializeData( | |||
| return nil, fmt.Errorf("%s: unable to get previously seen accounts", err.Error()) | |||
| } | |||
|
|
|||
| // We need to mark the bootstrapped accounts as "seen", | |||
| // otherwise they won't be reconciled until rosetta-cli restart. | |||
| if len(config.Data.BootstrapBalances) > 0 { | |||
There was a problem hiding this comment.
Bootstrap balance should be only used when historical balance is disabled, we may not leave this logic in the main code path to avoid breaking changes for other blockchains with historical balance enabled
There was a problem hiding this comment.
Thank you!
If the check:data configuration file does not contain a bootstrap balances file (as it should be the case for blockchains with historical balances enabled, if I understood correctly), then the newly added behavior is inactivated.
However, since historical balances lookup support is always desired and recommended, this PR can be closed, perhaps?
|
@andreibancioiu Can you provide more context in terms of the specific use case and reproducing steps? I would suggest to open an issue to add those information |
|
@shiatcb, @GeekArthur, thank you 🙏 I was able to verify the changes brought by the PR on both flows:
However, since historical balances lookup support is always desired and recommended, this PR can be closed, perhaps? |
|
Close this as historical balance lookup is supported and it's required to support |
Motivation
Currently, if
check:datais ran using abootstrap_balances.jsonfile, the reconciler does not see the bootstrapped accounts until the process is restarted (when the seen accounts are loaded frombalanceStorage). Under these circumstances, the bootstrapped accounts are not reconciled (unless rosetta-cli restarts).Solution
The proposed solution is to load the bootstrapped accounts from the
bootstrap_balances.jsonfile, if such a file is provided. Then, use these accounts (in addition to the ones loaded frombalancesStorage) to initialize the reconciler.Open questions
N / A