Export Internal Packages + Miscellaneous Bug Fixes

[patrick-ogrady]

Closes: #91

In this PR, all /internal packages are made external. A few developers have asked to use some of the storage-based packages for their own projects.

Changes

• Move all packages in /internal to /pkg
• Return *types.BlockIdentifier with CoinStorage.GetCoins
• Track coins on check:data
• Don't put genesis in block cache multiple times

2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache
2020/08/07 17:05:00 Added &{Index:0 Hash:000000000933ea01ad0ee984209779baaec3ced90fa3f408719526f8d77f4943} to cache

[coveralls]

Pull Request Test Coverage Report for Build 3352

• 17 of 26 (65.38%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.06%) to 71.628%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
configuration/configuration.go	1	3	33.33%
pkg/storage/coin_storage.go	9	16	56.25%

Totals
Change from base Build 3338:	-0.06%
Covered Lines:	1593
Relevant Lines:	2224

---

💛 - Coveralls

[qiwu7]

Should this file be in storage package if this implements storage.CoinStorageHelper?

[patrick-ogrady]

We need to do a big refactor on everything in processor. The whole package can likely be removed by aligning helper/handler interfaces with existing package interfaces. We would then just provide an instantiation of the fetcher (for example) instead of a processor that wraps the fetcher.