Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Mining Reward for Genesis Block #73

Closed
talevy opened this issue Nov 19, 2021 · 1 comment · Fixed by #87
Closed

Incorrect Mining Reward for Genesis Block #73

talevy opened this issue Nov 19, 2021 · 1 comment · Fixed by #87
Assignees
Labels
bug Something isn't working

Comments

@talevy
Copy link

talevy commented Nov 19, 2021

Describe the bug
I believe the miningReward calculation for the genesis block (height = 0) is possibly incorrect

https://github.com/coinbase/rosetta-ethereum/blob/79a9b97d0a3ed08ae151a3f313aa57b88dd128a4/ethereum/client.go#L971-L976

To Reproduce

curl -XPOST --head localhost:8080/block -d'{                                                                                                                                                            
  "network_identifier": {
    "blockchain": "Ethereum",
    "network": "Mainnet"
  },
  "block_identifier": {
    "index": 0
  }
}'

Expected behavior

The mining reward for the genesis block is 5 ETH. that is according to https://etherscan.io/block/0

Additional context

If this is expected, then that is fine by me too! just checking here because etherscan and rosetta mismatch here. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants