nits

coinbase · May 16, 2020 · 41088a3 · 41088a3
1 parent 0bdff7d
commit 41088a3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/reconciler/configuration.go b/reconciler/configuration.go
@@ -33,7 +33,7 @@ func WithInactiveConcurrency(concurrency int) Option {
 	}
 }
 
-// WithActiveConcurrency overrides the default inactive
+// WithActiveConcurrency overrides the default active
 // concurrency.
 func WithActiveConcurrency(concurrency int) Option {
 	return func(r *Reconciler) {

diff --git a/reconciler/reconciler.go b/reconciler/reconciler.go
@@ -489,7 +489,7 @@ func (r *Reconciler) accountReconciliation(
 			return nil
 		}
 
-		err = r.inactiveAccountQueue(ctx, inactive, accountCurrency, liveBlock)
+		err = r.inactiveAccountQueue(inactive, accountCurrency, liveBlock)
 		if err != nil {
 			return err
 		}
@@ -508,7 +508,6 @@ func (r *Reconciler) accountReconciliation(
 }
 
 func (r *Reconciler) inactiveAccountQueue(
-	ctx context.Context,
 	inactive bool,
 	accountCurrency *AccountCurrency,
 	liveBlock *types.BlockIdentifier,
@@ -637,7 +636,6 @@ func (r *Reconciler) Reconcile(ctx context.Context) error {
 		g.Go(func() error {
 			return r.reconcileActiveAccounts(ctx)
 		})
-
 	}
 
 	for j := 0; j < r.inactiveConcurrency; j++ {

diff --git a/reconciler/reconciler_test.go b/reconciler/reconciler_test.go
@@ -523,7 +523,6 @@ func TestInactiveAccountQueue(t *testing.T) {
 
 	t.Run("new account in active reconciliation", func(t *testing.T) {
 		err := r.inactiveAccountQueue(
-			context.Background(),
 			false,
 			accountCurrency,
 			block,
@@ -540,7 +539,6 @@ func TestInactiveAccountQueue(t *testing.T) {
 
 	t.Run("another new account in active reconciliation", func(t *testing.T) {
 		err := r.inactiveAccountQueue(
-			context.Background(),
 			false,
 			accountCurrency2,
 			block2,
@@ -567,7 +565,6 @@ func TestInactiveAccountQueue(t *testing.T) {
 		r.inactiveQueue = []*InactiveEntry{}
 
 		err := r.inactiveAccountQueue(
-			context.Background(),
 			false,
 			accountCurrency,
 			block,
@@ -583,7 +580,6 @@ func TestInactiveAccountQueue(t *testing.T) {
 
 	t.Run("previous account in inactive reconciliation", func(t *testing.T) {
 		err := r.inactiveAccountQueue(
-			context.Background(),
 			true,
 			accountCurrency,
 			block,
@@ -604,7 +600,6 @@ func TestInactiveAccountQueue(t *testing.T) {
 
 	t.Run("another previous account in inactive reconciliation", func(t *testing.T) {
 		err := r.inactiveAccountQueue(
-			context.Background(),
 			true,
 			accountCurrency2,
 			block2,