Fetch by Index + Orphan Race Fix #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10287
💛 - Coveralls |
patrick-ogrady
changed the title
patrick-ogrady
changed the title
qiwu7
previously approved these changes
Oct 29, 2020
|
@patrick-ogrady looks like there are some failing tests 🤔 |
|
Yep! Sorry this is still WIP in-progress @qiwu7. Was planning a lightweight PR and then decided it was a good opportunity to clean up some other potential races. |
patrick-ogrady
commented
Oct 29, 2020
| // If this is the case, we continue reconciling. | ||
| canonical, canonicalErr := r.helper.CanonicalBlock(ctx, lookupBlock) | ||
| if canonicalErr != nil { | ||
| if err != nil { |
There was a problem hiding this comment.
We no longer expect this to error in the case of a re-org, so we don't need custom handling. CompareBalance can handle the case where a non-canonical block is returned by this call.
patrick-ogrady
changed the title
patrick-ogrady
force-pushed
the
patrick/update-currency-balance-helper
branch
from
166a762
to
003d728
Compare
arjun-io
reviewed
Oct 29, 2020
arjun-io
previously approved these changes
Oct 29, 2020
patrick-ogrady
changed the title
arjun-io
approved these changes
Oct 29, 2020
qiwu7
approved these changes
Oct 29, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
utils.CurrencyBalanceto fetch by index instead of by hash. This fixes an issue where thereconcilerrequests balances of orphaned blocks (by hash) when processing reconciliations near tip. This PR also addresses a potential race condition where a reorg occurs while comparing balance.Changelog
utils.CurrencyBalanceto only lookup historical balances by index (up to the caller to determine if canonical)reconciler.AccountCurrencytotypes.AccountCurrency(storageshould not be depending onreconciler)ReconcilerHelperinterface to be more transparent about guarantees