Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reconciler] Inactive Pruning Race #221

Merged
merged 6 commits into from
Nov 5, 2020
Merged

[reconciler] Inactive Pruning Race #221

merged 6 commits into from
Nov 5, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Nov 5, 2020 •
edited
Loading

This PR fixes an inactive pruning race (where the active reconciliation loop prunes a balance being used by the inactive reconciliation loop).

Changes

  • reproduce race condition in tests
  • fix race condition

@patrick-ogrady patrick-ogrady changed the title [reconciler] Inactive Pruning Race [reconciler] Inactive Pruning Race + Inactive Pruning Support Nov 5, 2020
@coveralls
Copy link

coveralls commented Nov 5, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 10683

  • 37 of 44 (84.09%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 79.071%
Changes Missing Coverage Covered Lines Changed/Added Lines %
reconciler/reconciler.go 37 44 84.09%
Files with Coverage Reduction New Missed Lines %
reconciler/reconciler.go 1 83.91%
Totals Coverage Status
Change from base Build 10631: -0.02%
Covered Lines: 7352
Relevant Lines: 9298
💛 - Coveralls

arjun-io
arjun-io reviewed Nov 5, 2020
View reviewed changes
reconciler/reconciler.go Outdated Show resolved Hide resolved
arjun-io
arjun-io previously approved these changes Nov 5, 2020
View reviewed changes
@patrick-ogrady patrick-ogrady merged commit 09da071 into master Nov 5, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/inactive-reconciler-pruning-race branch November 5, 2020 01:18
@patrick-ogrady patrick-ogrady mentioned this pull request Nov 5, 2020
Merged
@patrick-ogrady patrick-ogrady changed the title [reconciler] Inactive Pruning Race + Inactive Pruning Support [reconciler] Inactive Pruning Race Nov 5, 2020
This was referenced Nov 5, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjun-io arjun-io arjun-io approved these changes

@qiwu7 qiwu7 Awaiting requested review from qiwu7

@yfl92 yfl92 Awaiting requested review from yfl92

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patrick-ogrady @coveralls @arjun-io