Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] v1.4.7 Upgrade #231

Merged
merged 10 commits into from
Nov 6, 2020
Merged

[chore] v1.4.7 Upgrade #231

merged 10 commits into from
Nov 6, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Nov 6, 2020

This PR updates rosetta-sdk-go to use rosetta-specifications@v1.4.7. Notably, this adds support for "indexer" endpoints!

Changelog

  • update codegen.sh
  • add types.X methods for string, int64, and bool to make it easier to handle pointers
  • pass existing tests

Future PR

  • add new endpoints to fetcher
  • add assertions for new endpoints (both client + server)

@coveralls
Copy link

coveralls commented Nov 6, 2020

Pull Request Test Coverage Report for Build 11011

  • 22 of 54 (40.74%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 78.924%

Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/block.go 12 14 85.71%
asserter/asserter.go 2 5 40.0%
fetcher/account.go 8 11 72.73%
types/utils.go 0 9 0.0%
asserter/server.go 0 15 0.0%
Files with Coverage Reduction New Missed Lines %
asserter/block.go 1 90.21%
Totals Coverage Status
Change from base Build 10952: -0.2%
Covered Lines: 7392
Relevant Lines: 9366

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants