Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] v1.4.7 Upgrade (Part 2) #232

Merged
merged 21 commits into from
Nov 6, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Nov 6, 2020

Related: #231

This PR adds support for new endpoints in the fetcher and asserter package.

Changes

  • add support for new methods in fetcher
  • add support for new methods in asserter
  • add tests for new fetcher methods
  • add test for new server methods in asserter
  • add tests for new response methods in asserter

@coveralls
Copy link

coveralls commented Nov 6, 2020

Pull Request Test Coverage Report for Build 11119

  • 253 of 337 (75.07%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 78.872%

Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/search.go 13 15 86.67%
asserter/account.go 14 22 63.64%
fetcher/account.go 52 70 74.29%
fetcher/events.go 47 65 72.31%
fetcher/search.go 39 57 68.42%
asserter/server.go 57 77 74.03%
Totals Coverage Status
Change from base Build 11016: -0.05%
Covered Lines: 7649
Relevant Lines: 9698

💛 - Coveralls

Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@patrick-ogrady patrick-ogrady merged commit 1e6eb64 into master Nov 6, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/v1.4.7-part-2 branch November 6, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants