[chore] rosetta-specifications@v1.4.9
#271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
septerr
reviewed
Dec 8, 2020
| @@ -78,6 +78,27 @@ func Version(version *types.Version) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // SyncStatus ensures any types.SyncStatus is valid. | |||
| func SyncStatus(status *types.SyncStatus) error { | |||
There was a problem hiding this comment.
Since this always returns error (or nil), I'd prefer a name like SyncStatusError or ValidateSyncStatus. What do you think?
There was a problem hiding this comment.
This is consistent with all other functions in asserter. Currently, the pattern is that the name of the asserter method is the name of the struct it is asserting.
If we want to migrate to your naming strategy, I'd recommend we do that in a separate PR.
septerr
approved these changes
Dec 8, 2020
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
rosetta-sdk-goto the latest release ofrosetta-specifications. This is a pretty minor release compared to other recent releases.Changelog
SyncStatusSearchTransactionsResponse.TotalCountrosetta-specificationsChangelogSyncedStatus#71total_countfield#70