Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fetcher] Optionally Force Retry #275

Merged
merged 3 commits into from
Dec 11, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 11, 2020

This PR allows the caller to specify that all non-200 responses from a Rosetta implementation should be retried. This is particularly useful when accessing a Rosetta implementation through a load balancer where there may be periods of inconsistency (i.e. we get a network status from one implementation and query another that has not yet synced the most recent block).

Changes

  • Add WithForceRetry option to fetcher
  • Add test

Future Work

  • Add force_retry to rosetta-cli

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13627

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 78.062%

Totals Coverage Status
Change from base Build 13595: 0.008%
Covered Lines: 8095
Relevant Lines: 10370

💛 - Coveralls

Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heimdall-asguard
Copy link

Review Error for yflinn @ 2020-12-11 19:12:41 UTC
User failed mfa authentication, see go/mfa-help

@patrick-ogrady patrick-ogrady merged commit 9354c66 into master Dec 11, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/force-retry branch December 11, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants