Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [MDS-527] Extract out figma_squircle logic and fix various issues #172

Merged
merged 4 commits into from
May 22, 2023
Merged

fix: [MDS-527] Extract out figma_squircle logic and fix various issues #172

merged 4 commits into from
May 22, 2023

Conversation

Kypsis
Copy link
Collaborator

@Kypsis Kypsis commented May 19, 2023 •
edited
Loading

  • Fix border alignment issues
  • Fix cornerSmoothing 1.0 leading to NaN on mobile web/PWA?
  • Evaluate using math from the discarded squircle PR from the Flutter repo

@Kypsis Kypsis self-assigned this May 19, 2023
@Kypsis Kypsis marked this pull request as ready for review May 20, 2023 23:43
@GittHub-d GittHub-d self-requested a review May 22, 2023 07:29
@Kypsis Kypsis merged commit 08e7752 into main May 22, 2023
2 checks passed
@github-actions github-actions bot mentioned this pull request May 22, 2023
Merged
@Kypsis Kypsis deleted the fix/MDS-527 branch July 30, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GittHub-d GittHub-d GittHub-d approved these changes

Assignees

@Kypsis Kypsis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kypsis @GittHub-d