Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Novaexchange volume glitch #58

Closed
tmlee opened this issue Aug 1, 2017 · 2 comments
Closed

Novaexchange volume glitch #58

tmlee opened this issue Aug 1, 2017 · 2 comments
Labels
bug

Comments

@tmlee
Copy link
Member

tmlee commented Aug 1, 2017 •
edited
Loading

@yihangho We implemented novaexchange to have the base/target switched.
However the novaexchange API returns the volume based on their API base

For instance

screen shot 2017-08-02 at 1 39 50 am

and the API results
screen shot 2017-08-02 at 1 39 45 am

On their API pair of BTC_ETH which translates to base of ETH and target BTC.
The volume needs to be in terms of ETH, however the API returns in BTC terms
@tmlee tmlee added the bug label Aug 1, 2017
@tmlee tmlee mentioned this issue Aug 4, 2017
Merged
@tmlee
Copy link
Member Author

tmlee commented Aug 14, 2017

Fix with https://github.com/coingecko/cryptoexchange/pull/73/files

@tmlee tmlee mentioned this issue Aug 14, 2017
Closed
@tmlee
Copy link
Member Author

tmlee commented Aug 15, 2017

PR merged

@tmlee tmlee closed this as completed Aug 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tmlee