cointop --version does not display current version

[githorray]

$ cointop --version
dev$

https://github.com/miguelmota/cointop/blob/6f286490beb89ab332d02f7ab1658782066ef38b/cointop/version.go#L9

[miguelmota]

@githorray thanks it's definitely a bug where the release builder is not setting it

[miguelmota]

@githorray question; how did you install cointop? with brew, a linux package manager, or go get?

[githorray]

Both go get and Ubuntu Software.

Ubuntu Software had an update today for version 1.5.1

$ cointop --version
v1.5.1$

Now it shows a version number instead of dev or unknown.

It might be helpful to add a newline after the version number.

From go get now after 1.5.1.

$ cointop --version
(unknown)$

Thanks.

[miguelmota]

@githorray thanks for checking. For go get, it'll require the GO111MODULE environment variable in order to build with the version from the tagged release

GO111MODULE=on go get github.com/miguelmota/cointop

I'll add the new line too, thanks again.

[githorray]

Confirmed, working.

$ GO111MODULE=on go get -u github.com/miguelmota/cointop
go: downloading github.com/miguelmota/cointop v1.5.1
go: github.com/miguelmota/cointop upgrade => v1.5.1
go: downloading github.com/inconshreveable/mousetrap v1.0.0
go: github.com/spf13/pflag upgrade => v1.0.5
go: golang.org/x/text upgrade => v0.3.3
go: github.com/anaskhan96/soup upgrade => v1.1.1
go: golang.org/x/sys upgrade => v0.0.0-20200805065543-0cf7623e9dbd
go: golang.org/x/net upgrade => v0.0.0-20200707034311-ab3426394381
go: golang.org/x/crypto upgrade => v0.0.0-20200728195943-123391ffb6de
go: github.com/miguelmota/go-coinmarketcap upgrade => v0.1.6
go: github.com/mattn/go-runewidth upgrade => v0.0.9
go: github.com/mattn/go-isatty upgrade => v0.0.12
go: github.com/mattn/go-colorable upgrade => v0.1.7
go: github.com/fatih/color upgrade => v1.9.0
go: github.com/maruel/panicparse upgrade => v1.5.0
go: downloading github.com/fatih/color v1.9.0
go: downloading golang.org/x/text v0.3.3
go: downloading golang.org/x/sys v0.0.0-20200805065543-0cf7623e9dbd
go: downloading github.com/maruel/panicparse v1.5.0
go: downloading github.com/miguelmota/go-coinmarketcap v0.1.6
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/mattn/go-colorable v0.1.7
go: downloading golang.org/x/net v0.0.0-20200707034311-ab3426394381

$ cointop --version
v1.5.1$

[miguelmota]

Closed by 523c430 and 0fed4d5