Primitives

[sarda-nikhil]

There are some whitespace issues. What editor are you using? If its emacs, can you please send me your elisp file. Thanks!

[sarda-nikhil]

Ok so there were superfluous white spaces in your code. Can you please configure your editor to strip away whitespaces before saving as its really annoying when doing a git diff.

[colah]

Hey!

Sorry about the delayed response. One of my friends is on trial and I've been spending all my time note taking/transcribing.

I'm not using emacs, unfortunately. I'm too lazy to get good with a real text editor like vim or emacs and just use gedit :/

As to the changes you've made:

CLRF issues: I don't know how those happened. I don't think I've ever edited this on a non-Linux computer.

Superfluous White Space: I'm happy accept those changes and will try to avoid that in the future. That said, I'd prefer to not make it a rule about committing to ImplicitCAD -- keeping down barriers to entry and all that. It may be possible to add a sed script to get rid of them as a git commit hook. I'll look into that.

Uncommenting ellipse: That ellipse code has some issues. I should have left a comment explaining that. My bad.

[sarda-nikhil]

Wow, you do have some very interesting friends :D

I would really really recommend that you start using emacs. Its a good habit to cultivate and pays dividends later.

I have been committing (or trying at least) to a few well established projects, where each pull request goes through 5-6 iterations. Just to let you know where I have been coming from :)
Sorry if I sound to anal, but there is a purpose to this. YOU do NOT want substandard code/commits in your project. It always helps to have a workflow defined. I will prepare a wiki page detailing one if its ok with you after I have some more code in. Anyway, its your call.

Not withstanding the OpenGL work, on the CAD front, what are the major parts that need to be done?

[colah]

I would really really recommend that you start using emacs. Its a good habit to cultivate and pays dividends later.

I'm sure. Right now I have too many other things eating at my time, though...

I have been committing (or trying at least) to a few well established projects, where each pull request goes through 5-6 iterations. Just to let you know where I have been coming from :)

Sure.

Sorry if I sound to anal, but there is a purpose to this. YOU do NOT want substandard code/commits in your project. It always helps to have a workflow defined. I will prepare a wiki page detailing one if its ok with you after I have some more code in. Anyway, its your call.

How about we cross that bridge when we come to it? If we end up with
several commiters, we may need t address it, but with the few that
there are right now (you, me, and maybe Kate), it seems like
unnecessary overheard.

Not withstanding the OpenGL work, on the CAD front, what are the major parts that need to be done?

You may regret asking that :)

(1) Implicit.Tracing.GetTriangles.getTriangles is missing some cases.
Like half of them. If you're feeling particularity masochistic, you
can work on that. The ones that are missing aren't that important --
if you run into one, for a non-fractal object, you should be able to
avoid it my increasing your resolution. But it would be nice to fix
it.

(2) Something needs to be done about Implicit.Export. And by
something, I mean restructuring so that it can easily target lots of
formats and platforms. Roughly, I think the big categories are:

3D
Milling Machines
3D Printers
Triangle Mesh Formats
2D
Laser Cutters
Line Segment Path Formats

So you would have high level generators (that takes some configs) that
turn the object into some intermediate format for all of those, and
then lots of low level generators that handle the specifics of the
format. At my GTALUG talk, people suggested I should research GCC's
architecture regarding this.

(3) Examples. Enough said.

(4) OpenGL viewer for objects. This should be to bad with hopengl,
since we already have triangles.

(5) extended openscad parser. We need backwards compatibility with
openscad, and to make it a way better format. I have some ideas for
this that I'd like to implement before others start hacking on it, to
keep things sane.

(5b) I'm thinking it might be interesting to experiment with
including bounding boxes with objects, so that users don't have to
bother specifying them. I'm going to experiment with it in
extopenscad, and we can see from there...

(6) Standard libraries. Gears, mountings, propellers, anything you
think might be useful. We may be able to get a substantial amount of
this from mcad via the extopenscad parser. (Side note: I'd like to
have a sort of contrib section that's fairly easy to get libraries
into and ships with ImplicitCAD. It would make things more convenient
for the end user...)

That's what comes to mind right now :)

Chris

---

Reply to this email directly or view it on GitHub:
#1 (comment)