Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and documentation/vignette suggestion #50

Closed
mebbert opened this issue Sep 26, 2017 · 1 comment
Closed

Code and documentation/vignette suggestion #50

mebbert opened this issue Sep 26, 2017 · 1 comment
Assignees

Comments

@mebbert
Copy link

mebbert commented Sep 26, 2017

Hi,

Loving Monocle. I have a small suggestion in the code and documentation/vignette. Perhaps I've misunderstood, so correct me if I'm wrong.

I noticed the call to estimate size factors and dispersion is buried at the bottom of a section Converting TPM to mRNA counts that not everyone needs. I skipped that section since I have UMI counts and proceeded with remaining sections, including differential expression. I assumed I had performed any required steps up to that point, and that any other necessary calculations were within the differentialGeneTest call.

My suggestion would be to place the documentation for estimateSizeFactors and estimateDispersions in a more general location. I also think it would be helpful to add a warning or error if someone runs differentialGeneTest without running important steps prior.

Or, have I misunderstood something?

Really appreciate it!

@Xiaojieqiu
Copy link
Collaborator

Hi mebbert,

Thanks a lot for your comment, that is right, descriptions about estimateSizeFactors and estimateDispersions should be moved to a more general place. We will update this to our online vignettee soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants