Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.2 release breaks FlaskAdmin #1442

Closed
brunson opened this issue Jan 30, 2018 · 4 comments
Closed

3.0.2 release breaks FlaskAdmin #1442

brunson opened this issue Jan 30, 2018 · 4 comments

Comments

@brunson
Copy link

brunson commented Jan 30, 2018

When upgrading to peewee 3.0.2 from 2.10.2 the contrib.peewee module for flask_admin fails attempting to import PrimaryKeyField from peewee.

@coleifer
Copy link
Owner

I'm not the maintainer of Flask-Admin. You can see in the changes that PrimaryKeyField has been renamed to AutoField.

To simplify updating, I suppose I can add a shim that logs a DeprecationWarning if you try to use PrimaryKeyField, however. This will give other maintainers some warning to upgrade their code. WDYT?

@coleifer
Copy link
Owner

Pushed 3.0.4, which adds a shim for PrimaryKeyField, which raises a DeprecationWarning if you attempt to use it. This should give folks time to update their codes.

@brunson
Copy link
Author

brunson commented Jan 30, 2018

Wow, that's awesome. I created an issue for the flask_admin maintainer: mrjoes/flask-admin#42

Thanks for the amazing turn around!

@coleifer
Copy link
Owner

Of course, thanks for reporting the issue. 3.0 is a major release and I want to be sure to make the transition as smooth as possible for folks upgrading. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants