Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why ForeignKeyAccessor.__set__() doesn't update instance._dirty? #1530

Closed
TwoAnts opened this issue Mar 9, 2018 · 1 comment
Closed

Why ForeignKeyAccessor.__set__() doesn't update instance._dirty? #1530

TwoAnts opened this issue Mar 9, 2018 · 1 comment

Comments

@TwoAnts
Copy link

TwoAnts commented Mar 9, 2018

I use = to set a ForeignKeyField and call save() method, but it doesn't take effect.

When I read the source code in peewee.py, I found that ForeignKeyAccessor.__set__() seems not to update the instance._dirty . This leads to a failure to update ForeignKeyField by calling save() method.

Please fix it, if it is a bug.
@coleifer
Copy link
Owner

coleifer commented Mar 9, 2018

Fixed, thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coleifer @TwoAnts