Should count() default to wrapped_count() when query contains a limit or offset?

[bryhoyt]

As far as I can tell, count() returns meaningless results when the query contains a limit or offset (neither the total, nor the limited, number of results).

As per the docs, "count() will automatically default to wrapped_count() in the event the query is distinct or has a grouping".

I think that's nice; exactly what you want in the case of distinct or group by. Wouldn't it make sense for it to do the same if the query has a limit or offset?

If not, what's the rationale behind that?

[bryhoyt]

Additionally, I think count() should have a clear_limit parameter which it passes through to wrapped_count() -- I'm mentioning this as a comment here, not a separate issue, because it would only make sense if count deferred to wrapped_count for limits and offsets.

[coleifer]

I think that's nice; exactly what you want in the case of distinct or group by. Wouldn't it make sense for it to do the same if the query has a limit or offset?

Yeah, now that I think about it I agree.

[bryhoyt]

Thanks, looks great -- really appreciate the quick fixes. I'm loving using Peewee with Flask -- thanks for the great ORM!