Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install: dependencies are missing from setup.py #5

Closed
e3krisztian opened this issue Apr 7, 2015 · 0 comments
Closed

pip install: dependencies are missing from setup.py #5

e3krisztian opened this issue Apr 7, 2015 · 0 comments

Comments

@e3krisztian
Copy link

I expect pip install to install all of the dependencies needed to run the application.

from the README:

Installation

$ pip install sqlite-browser flask peewee

setup.py has support for dependencies via the parameter install_requires! Indeed this parameter is existing but empty in the project's setup.py

Changing it to

install_requires=[
    'Flask',
    'peewee',
],

would simplify the installation as well as the documentation.


Background info:
I found sqlite_browser via search on github.

When I was about installing it I glanced over the README, and saw OK, this is a standard python pip install instruction - obviously missing the extra packages.
So I simply created a new virtualenv and run

pip install sqlite-browser

which did not work (ImportError: No module named flask)

pip install flask

ImportError: No module named peewee

pip install peewee

and finally success.

Dependencies in setup.py also help installing via other tools, e.g. creating a PEX bundle with

$ pex -r sqlite_browser -e sqlite_browser.sqlite_browser:main -o sqlite_browser

instead of the longer

$ pex -r sqlite_browser -r flask -r peewee -e sqlite_browser.sqlite_browser:main -o sqlite_browser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant